New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nginx for running Selenium tests #13657

Merged
merged 2 commits into from Sep 6, 2017

Conversation

Projects
None yet
1 participant
@nijel
Member

nijel commented Sep 6, 2017

It is supposed to perform better than PHP built in server.

Signed-off-by: Michal Čihař michal@cihar.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@nijel nijel self-assigned this Sep 6, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 6, 2017

Codecov Report

Merging #13657 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #13657   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         477      477           
  Lines       81824    81824           
=======================================
  Hits        44076    44076           
  Misses      37748    37748

codecov bot commented Sep 6, 2017

Codecov Report

Merging #13657 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master   #13657   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         477      477           
  Lines       81824    81824           
=======================================
  Hits        44076    44076           
  Misses      37748    37748

nijel added some commits Sep 6, 2017

Silent possible warnings from open basedir
Signed-off-by: Michal Čihař <michal@cihar.com>
Use nginx for running Selenium tests
It is supposed to perform better than PHP built in server.

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel referenced this pull request Sep 6, 2017

Closed

Random failures on selenium #13591

4 of 4 tasks complete

@nijel nijel merged commit b9b6b45 into phpmyadmin:master Sep 6, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details

@nijel nijel deleted the nijel:selenium-nginx branch Sep 6, 2017

@nijel nijel added this to the 4.8.0 milestone Sep 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment