New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change password shown behind navigation #13662 #13664

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@shucon
Contributor

shucon commented Sep 7, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Sep 7, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on bcbc899 Sep 7, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Sep 7, 2017

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: themes/original/jquery/jquery-ui.css, themes/pmahomme/jquery/jquery-ui.css

phpmyadmin-bot replied Sep 7, 2017

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: themes/original/jquery/jquery-ui.css, themes/pmahomme/jquery/jquery-ui.css

@@ -53,7 +53,7 @@
}
.ui-front {
z-index: 100;
z-index: 800;

This comment has been minimized.

@nijel

nijel Sep 7, 2017

Member

AFAIK this is original file coming with jQuery UI, so better to override it in our CSS to avoid problems on jQuery UI upgrades...

@nijel

nijel Sep 7, 2017

Member

AFAIK this is original file coming with jQuery UI, so better to override it in our CSS to avoid problems on jQuery UI upgrades...

This comment has been minimized.

@shucon

shucon Sep 7, 2017

Contributor

Where is the CSS being overrided ? I think the 1 is added to the z-index value of ui-front but can't find it.

@shucon

shucon Sep 7, 2017

Contributor

Where is the CSS being overrided ? I think the 1 is added to the z-index value of ui-front but can't find it.

This comment has been minimized.

@nijel

nijel Sep 7, 2017

Member

There is probably no override for this element yet, has to be added to common.css.php.

@nijel

nijel Sep 7, 2017

Member

There is probably no override for this element yet, has to be added to common.css.php.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Sep 7, 2017

Codecov Report

Merging #13664 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13664   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         477      477           
  Lines       81850    81850           
=======================================
  Hits        44088    44088           
  Misses      37762    37762

codecov bot commented Sep 7, 2017

Codecov Report

Merging #13664 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13664   +/-   ##
=======================================
  Coverage   53.86%   53.86%           
=======================================
  Files         477      477           
  Lines       81850    81850           
=======================================
  Hits        44088    44088           
  Misses      37762    37762
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Sep 7, 2017

Member

Closing in favor of #13665.

Member

nijel commented Sep 7, 2017

Closing in favor of #13665.

@nijel nijel closed this Sep 7, 2017

@nijel nijel self-assigned this Sep 7, 2017

@shucon shucon deleted the shucon:newbie-2 branch Mar 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment