New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table column name #13736

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@shucon
Contributor

shucon commented Oct 12, 2017

Fixes #13727

Signed-off-by: Saksham Gupta shucon01@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix table column name
Fixes #13727

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Oct 12, 2017

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: libraries/classes/Display/Results.php

phpmyadmin-bot commented on 5e28958 Oct 12, 2017

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: libraries/classes/Display/Results.php

Trailing Spaces Fix
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #13736 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13736      +/-   ##
==========================================
- Coverage   53.81%   53.81%   -0.01%     
==========================================
  Files         482      482              
  Lines       82177    82181       +4     
==========================================
  Hits        44222    44222              
- Misses      37955    37959       +4

codecov bot commented Oct 12, 2017

Codecov Report

Merging #13736 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master   #13736      +/-   ##
==========================================
- Coverage   53.81%   53.81%   -0.01%     
==========================================
  Files         482      482              
  Lines       82177    82181       +4     
==========================================
  Hits        44222    44222              
- Misses      37955    37959       +4
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 28, 2017

Member

Thanks for your PR, however the numbers are important to show ordering in case of multiple ORDER BY clauses.

Member

nijel commented Nov 28, 2017

Thanks for your PR, however the numbers are important to show ordering in case of multiple ORDER BY clauses.

@nijel nijel closed this Nov 28, 2017

@nijel nijel self-assigned this Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment