New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for password change issues on Galera cluster #13737

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@Seitanas
Contributor

Seitanas commented Oct 12, 2017

Hello,
this patch fixes issue with changing passwords on Galera cluster.
The problem is, that user tables are stored in MyISAM storage engine, so changing password with
ordinary UPDATE queries will not be replicated. MariaDB uses SET PASSWORD command to update user credentials, which is a DDL command. DDL commands are replicated, thus phpMyAdmin should use SET PASSWORD on MariaDB versions 10 and above.

Signed-off-by: Tadas Ustinavičius tadas@ring.lt

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix for password change issues on Galera cluster
Signed-off-by: Tadas Ustinavičius <tadas@ring.lt>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 12, 2017

Codecov Report

Merging #13737 into QA_4_7 will decrease coverage by <.01%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           QA_4_7   #13737      +/-   ##
==========================================
- Coverage   52.71%    52.7%   -0.01%     
==========================================
  Files         467      467              
  Lines       80303    80311       +8     
==========================================
  Hits        42329    42329              
- Misses      37974    37982       +8

codecov bot commented Oct 12, 2017

Codecov Report

Merging #13737 into QA_4_7 will decrease coverage by <.01%.
The diff coverage is 11.11%.

@@            Coverage Diff             @@
##           QA_4_7   #13737      +/-   ##
==========================================
- Coverage   52.71%    52.7%   -0.01%     
==========================================
  Files         467      467              
  Lines       80303    80311       +8     
==========================================
  Hits        42329    42329              
- Misses      37974    37982       +8
@Seitanas

This comment has been minimized.

Show comment
Hide comment
@Seitanas

Seitanas Oct 13, 2017

Contributor

I assume checks failed because I've checked "Any new functionality is covered by tests", but there are no tests produced?

Contributor

Seitanas commented Oct 13, 2017

I assume checks failed because I've checked "Any new functionality is covered by tests", but there are no tests produced?

@Seitanas

This comment has been minimized.

Show comment
Hide comment
@Seitanas

Seitanas Nov 9, 2017

Contributor

Hello,
any progress on this issue?

Contributor

Seitanas commented Nov 9, 2017

Hello,
any progress on this issue?

@nijel nijel merged commit 2242a24 into phpmyadmin:QA_4_7 Nov 28, 2017

2 of 5 checks passed

codacy/pr Codacy was unable to analyse your pull request.
Details
codecov/patch 11.11% of diff hit (target 52.71%)
Details
codecov/project 52.7% (-0.01%) compared to 683884c
Details
DCO All commits have a DCO sign-off from the author
continuous-integration/travis-ci/pr The Travis CI build passed
Details

nijel added a commit that referenced this pull request Nov 28, 2017

nijel added a commit that referenced this pull request Nov 28, 2017

Set $sql_query as well when changing password
Issue #13737

Signed-off-by: Michal Čihař <michal@cihar.com>

nijel added a commit that referenced this pull request Nov 28, 2017

Changelog entry for #13737
Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 28, 2017

Member

Thanks for your contribution, merged with following changes:

Member

nijel commented Nov 28, 2017

Thanks for your contribution, merged with following changes:

@nijel nijel self-assigned this Nov 28, 2017

ibennetch added a commit that referenced this pull request Dec 1, 2017

ibennetch added a commit that referenced this pull request Dec 1, 2017

Set $sql_query as well when changing password
Issue #13737

Signed-off-by: Michal Čihař <michal@cihar.com>

ibennetch added a commit that referenced this pull request Dec 1, 2017

Changelog entry for #13737
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment