New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add word wrap in export option heading-2 (H2) #13746

Merged
merged 3 commits into from Oct 19, 2017

Conversation

Projects
None yet
2 participants
@anantjain6
Contributor

anantjain6 commented Oct 16, 2017

Patch #13745
Signed-off-by: Anant Jain anantjain60@gmail.com

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Add word wrap in export option heading-2 (H2)
Patch #13745
Signed-off-by: Anant Jain <anantjain60@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 16, 2017

Codecov Report

Merging #13746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13746   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973

codecov bot commented Oct 16, 2017

Codecov Report

Merging #13746 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13746   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Oct 16, 2017

Member

The same code probably should be added to the original theme.

Member

nijel commented Oct 16, 2017

The same code probably should be added to the original theme.

anantjain6 added some commits Oct 16, 2017

Add word wrap in export option heading-2 (H2)
Patch #13745
Signed-off-by: Anant Jain <anantjain60@gmail.com>
Merge pull request #3 from anantjain6/patch-6
In original theme Add word wrap in export option heading-2 (H2)
@anantjain6

This comment has been minimized.

Show comment
Hide comment
@anantjain6

anantjain6 Oct 16, 2017

Contributor

@nijel Thanks for notifying it to me
I added a commit 1acd230

Contributor

anantjain6 commented Oct 16, 2017

@nijel Thanks for notifying it to me
I added a commit 1acd230

@nijel nijel self-assigned this Oct 19, 2017

@nijel nijel added this to the 4.8.0 milestone Oct 19, 2017

@nijel nijel merged commit ba4f362 into phpmyadmin:master Oct 19, 2017

6 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing ff0b198...beac769
Details
codecov/project 53.81% remains the same compared to ff0b198
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Oct 19, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Oct 19, 2017

Merged, thanks for your contribution!

@anantjain6

This comment has been minimized.

Show comment
Hide comment
@anantjain6

anantjain6 Oct 19, 2017

Contributor

My pleasure

Contributor

anantjain6 commented Oct 19, 2017

My pleasure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment