New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for table names being obscured when changing table structure #13749

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@ankitjain28may
Contributor

ankitjain28may commented Oct 16, 2017

Signed-off-by: Ankit Jain ankitjain28may77@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fixed #13748
Signed-off-by: Ankit Jain <ankitjain28may77@gmail.com>
@@ -612,7 +612,7 @@ function adjustPrefsNotification () {
var $prefsAutoShowing = ($prefsAutoLoad.css('display') !== 'none');
if ($prefsAutoShowing && $tableNameControl.length) {
$tableNameControl.css('top', '120px');
$tableNameControl.css('top', '55px');

This comment has been minimized.

@nijel

nijel Oct 16, 2017

Member

IMHO this code is not active in my case - the preferences loading box is not present....

@nijel

nijel Oct 16, 2017

Member

IMHO this code is not active in my case - the preferences loading box is not present....

This comment has been minimized.

@ankitjain28may

ankitjain28may Oct 16, 2017

Contributor

This function is triggred and it adds the inline styling i.e top = 120px to the div which creates this bug. I don't know through which its triggering but this is the cause for the bug.

@ankitjain28may

ankitjain28may Oct 16, 2017

Contributor

This function is triggred and it adds the inline styling i.e top = 120px to the div which creates this bug. I don't know through which its triggering but this is the cause for the bug.

This comment has been minimized.

@ankitjain28may

ankitjain28may Oct 18, 2017

Contributor

@nijel Any other suggestions ?

@ankitjain28may

ankitjain28may Oct 18, 2017

Contributor

@nijel Any other suggestions ?

This comment has been minimized.

@nijel

nijel Oct 19, 2017

Member

Apparently I've misunderstood the code, the fix works fine.

@nijel

nijel Oct 19, 2017

Member

Apparently I've misunderstood the code, the fix works fine.

@OlafvdSpek

This comment has been minimized.

Show comment
Hide comment
@OlafvdSpek

OlafvdSpek Oct 16, 2017

55px looks like a magic number, where does it come from?

OlafvdSpek commented on 7a9754a Oct 16, 2017

55px looks like a magic number, where does it come from?

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 16, 2017

Codecov Report

Merging #13749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13749   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973

codecov bot commented Oct 16, 2017

Codecov Report

Merging #13749 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13749   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973
@ankitjain28may

This comment has been minimized.

Show comment
Hide comment
@ankitjain28may

ankitjain28may Oct 16, 2017

Contributor

@OlafvdSpek Check out the css.

Contributor

ankitjain28may commented Oct 16, 2017

@OlafvdSpek Check out the css.

@ibennetch ibennetch changed the title from Fixed #13748 to Fix for table names being obscured when changing table structure Oct 18, 2017

@nijel nijel self-assigned this Oct 19, 2017

@nijel nijel added this to the 4.8.0 milestone Oct 19, 2017

@nijel nijel merged commit 6d40c96 into phpmyadmin:master Oct 19, 2017

6 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
codecov/patch Coverage not affected when comparing ff0b198...7a9754a
Details
codecov/project 53.81% remains the same compared to ff0b198
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Oct 19, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Oct 19, 2017

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment