New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive text for ASC/DESC sort order #13751

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@akritianand
Contributor

akritianand commented Oct 16, 2017

Replaced 1 with [Asc/Desc]
Signed-off-by: Akriti Anand anand.akriti@gmail.com
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Issue#13727
Replaced 1 with [Asc/Desc]
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Oct 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on 446ec29 Oct 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Oct 16, 2017

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/sql.js

phpmyadmin-bot replied Oct 16, 2017

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/sql.js

@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Oct 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on 3f794dc Oct 16, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 16, 2017

Codecov Report

Merging #13751 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13751   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973

codecov bot commented Oct 16, 2017

Codecov Report

Merging #13751 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13751   +/-   ##
=======================================
  Coverage   53.81%   53.81%           
=======================================
  Files         484      484           
  Lines       82228    82228           
=======================================
  Hits        44255    44255           
  Misses      37973    37973

@ibennetch ibennetch changed the title from Issue#13727 to More descriptive text for ASC/DESC sort order Oct 18, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 28, 2017

Member

Sorry, but this is wrong for several reasons:

  • there can be different numbers than just one, when there are multiple sort ordering defined
  • the text output should be localized
  • I'm not sure if it makes sense to include this in the output at all, therefore #13823 was merged
Member

nijel commented Nov 28, 2017

Sorry, but this is wrong for several reasons:

  • there can be different numbers than just one, when there are multiple sort ordering defined
  • the text output should be localized
  • I'm not sure if it makes sense to include this in the output at all, therefore #13823 was merged

@nijel nijel closed this Nov 28, 2017

@nijel nijel self-assigned this Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment