New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Create CODE_OF_CONDUCT.md #13755

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@nijel
Member

nijel commented Oct 18, 2017

I think it's useful to have one. This one comes from the ones suggested by GitHub and I think is good match for us.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Create CODE_OF_CONDUCT.md
I think it's useful to have one. This one comes from the ones suggested by GitHub and I think is good match for us.
@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Oct 18, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

phpmyadmin-bot commented on a06c58a Oct 18, 2017

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@nijel nijel changed the title from Create CODE_OF_CONDUCT.md to RFC: Create CODE_OF_CONDUCT.md Oct 18, 2017

@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Oct 18, 2017

Codecov Report

Merging #13755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13755   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files         485      485           
  Lines       82295    82295           
=======================================
  Hits        44266    44266           
  Misses      38029    38029

codecov bot commented Oct 18, 2017

Codecov Report

Merging #13755 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13755   +/-   ##
=======================================
  Coverage   53.78%   53.78%           
=======================================
  Files         485      485           
  Lines       82295    82295           
=======================================
  Hits        44266    44266           
  Misses      38029    38029
@madhuracj

This comment has been minimized.

Show comment
Hide comment
@madhuracj

madhuracj Oct 18, 2017

Member

+1
I wonder whether developers@phpmyadmin.net is the best place to report. Maybe, an email address to reach team or just the admins would be better? Because reporting to developers@phpmyadmin.net would not protect the confidentiality with regard to the identity of the reporter.

Member

madhuracj commented Oct 18, 2017

+1
I wonder whether developers@phpmyadmin.net is the best place to report. Maybe, an email address to reach team or just the admins would be better? Because reporting to developers@phpmyadmin.net would not protect the confidentiality with regard to the identity of the reporter.

@ibennetch

This comment has been minimized.

Show comment
Hide comment
@ibennetch

ibennetch Oct 18, 2017

Member

I agree with Madhura that we should change the email address to one that is not public. Aside from that, this is fine by me.

Member

ibennetch commented Oct 18, 2017

I agree with Madhura that we should change the email address to one that is not public. Aside from that, this is fine by me.

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Oct 19, 2017

Member

Landed as b916d5d with info@phpmyadmin.net as contact point, thanks for feedback.

Member

nijel commented Oct 19, 2017

Landed as b916d5d with info@phpmyadmin.net as contact point, thanks for feedback.

@nijel nijel closed this Oct 19, 2017

@nijel nijel deleted the add-code-of-conduct-1 branch Oct 19, 2017

@nijel nijel self-assigned this Oct 19, 2017

@nijel nijel added this to the 4.8.0 milestone Oct 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment