New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better rendering of icons in modern browsers #13786

Merged
merged 2 commits into from Nov 6, 2017

Conversation

Projects
None yet
2 participants
@smileytechguy
Contributor

smileytechguy commented Oct 30, 2017

This PR allows for icons to be rendered without antialiasing in modern browsers which support the image-rendering CSS rule.

This looks significantly better than before, especially with the original theme.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By (I am not sure how to do this, I used the GitHub web interface to make these commits)
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests (no new functionality)

Noah Overcash added some commits Oct 30, 2017

Fix pixel rendering in original theme
Signed-off-by: Noah Overcash <smileytechguy@icloud.com>
Fix pixel rendering in pmahomme theme
Signed-off-by: Noah Overcash <smileytechguy@icloud.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 6, 2017

Codecov Report

Merging #13786 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13786      +/-   ##
==========================================
+ Coverage   53.84%    53.9%   +0.05%     
==========================================
  Files         494      488       -6     
  Lines       82823    82256     -567     
==========================================
- Hits        44595    44337     -258     
+ Misses      38228    37919     -309

codecov bot commented Nov 6, 2017

Codecov Report

Merging #13786 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #13786      +/-   ##
==========================================
+ Coverage   53.84%    53.9%   +0.05%     
==========================================
  Files         494      488       -6     
  Lines       82823    82256     -567     
==========================================
- Hits        44595    44337     -258     
+ Misses      38228    37919     -309
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 6, 2017

Codecov Report

Merging #13786 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13786   +/-   ##
=======================================
  Coverage   53.84%   53.84%           
=======================================
  Files         494      494           
  Lines       82823    82823           
=======================================
  Hits        44595    44595           
  Misses      38228    38228

codecov bot commented Nov 6, 2017

Codecov Report

Merging #13786 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13786   +/-   ##
=======================================
  Coverage   53.84%   53.84%           
=======================================
  Files         494      494           
  Lines       82823    82823           
=======================================
  Hits        44595    44595           
  Misses      38228    38228
@smileytechguy

This comment has been minimized.

Show comment
Hide comment
@smileytechguy

smileytechguy Nov 6, 2017

Contributor

I have fixed the sign-off issue

Contributor

smileytechguy commented Nov 6, 2017

I have fixed the sign-off issue

@mauriciofauth mauriciofauth merged commit a608f06 into phpmyadmin:master Nov 6, 2017

5 checks passed

DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing ed9b7d5...27cdb27
Details
codecov/project 53.84% remains the same compared to ed9b7d5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Nov 6, 2017

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Nov 6, 2017

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Nov 6, 2017

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Nov 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment