New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PSR-1 for PHPUnit TestCase #13802

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Nov 6, 2017

Use PSR-1 while extending PHPUnit TestCase class. This will help us when to migrate to PHPUnit 6, that no longer support snake case namespaces.

Use PSR-1 for PHPUnit TestCase
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 6, 2017

Codecov Report

Merging #13802 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13802   +/-   ##
=======================================
  Coverage   53.84%   53.84%           
=======================================
  Files         494      494           
  Lines       82823    82823           
=======================================
  Hits        44595    44595           
  Misses      38228    38228

codecov bot commented Nov 6, 2017

Codecov Report

Merging #13802 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13802   +/-   ##
=======================================
  Coverage   53.84%   53.84%           
=======================================
  Files         494      494           
  Lines       82823    82823           
=======================================
  Hits        44595    44595           
  Misses      38228    38228

@nijel nijel merged commit 8657a28 into phpmyadmin:master Nov 8, 2017

3 of 6 checks passed

codecov/patch CI failed.
Details
codecov/project CI failed.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 8, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Nov 8, 2017

Merged, thanks for your contribution!

@nijel nijel self-assigned this Nov 8, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 8, 2017

@carusogabriel carusogabriel deleted the carusogabriel:phpunit branch Nov 8, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment