New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhpMyAdmin\Database\MultiTableQuery class #13811

Merged
merged 5 commits into from Nov 14, 2017

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Nov 14, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Nov 13, 2017

Refactor Database/MultiTableQuery to use DI
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Move columns template into form template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Refactor getFormHTML method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Move new_column template into form template
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Move query results logic into MultiTableQuery class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Nov 14, 2017

@mauriciofauth mauriciofauth self-assigned this Nov 14, 2017

@mauriciofauth mauriciofauth merged commit 702d6e6 into phpmyadmin:master Nov 14, 2017

2 of 4 checks passed

codacy/pr Not so good... This pull request quality could be better.
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 2 new issues, 2 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:query branch Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment