New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

min php version 5.5.9 #13812

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@Gemorroj
Contributor

Gemorroj commented Nov 14, 2017

symfony/expression-language 3.2 requires php 5.5.9
see https://github.com/symfony/expression-language/blob/3.2/composer.json#L19

Signed-off-by: Gemorroj wapinet@mail.ru

Gemorroj added some commits Nov 14, 2017

min php version 5.5.9
`symfony/expression-language` 3.2 requires php 5.5.9. see https://github.com/symfony/expression-language/blob/3.2/composer.json#L19
cosmetics
some js variables make local instead global.

Signed-off-by: Gemorroj wapinet@mail.ru
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 14, 2017

Codecov Report

Merging #13812 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13812   +/-   ##
=======================================
  Coverage   53.41%   53.41%           
=======================================
  Files         491      491           
  Lines       81701    81701           
=======================================
  Hits        43638    43638           
  Misses      38063    38063

codecov bot commented Nov 14, 2017

Codecov Report

Merging #13812 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #13812   +/-   ##
=======================================
  Coverage   53.41%   53.41%           
=======================================
  Files         491      491           
  Lines       81701    81701           
=======================================
  Hits        43638    43638           
  Misses      38063    38063
@@ -528,7 +528,7 @@ function PMA_current_version (data) {
var version_information_message_link = document.createElement('a');
version_information_message_link.href = url;
version_information_message_link.className = 'disableAjax';
version_information_message_link_text = document.createTextNode(data.version);
var version_information_message_link_text = document.createTextNode(data.version);

This comment has been minimized.

@ibennetch

ibennetch Nov 15, 2017

Member

This change seems to be unrelated to the PHP version so should probably be a separate commit.

However, since these changes are so small, it may be easier to just redo the commit in your name than to resubmit; so don't do anything yet until some other team member can comment on how they want to handle the changes.

@ibennetch

ibennetch Nov 15, 2017

Member

This change seems to be unrelated to the PHP version so should probably be a separate commit.

However, since these changes are so small, it may be easier to just redo the commit in your name than to resubmit; so don't do anything yet until some other team member can comment on how they want to handle the changes.

This comment has been minimized.

@Gemorroj

Gemorroj Nov 15, 2017

Contributor

I did it because I thought it would work "Signed-Off-By".

@Gemorroj

Gemorroj Nov 15, 2017

Contributor

I did it because I thought it would work "Signed-Off-By".

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 16, 2017

Member

I think it's better to keep the dependency consistent with motranslator to allow older PHP versions as well: https://github.com/phpmyadmin/motranslator/blob/86e6032aa89f5d139b34d03dce0099055c079fa9/composer.json#L20

Member

nijel commented Nov 16, 2017

I think it's better to keep the dependency consistent with motranslator to allow older PHP versions as well: https://github.com/phpmyadmin/motranslator/blob/86e6032aa89f5d139b34d03dce0099055c079fa9/composer.json#L20

@nijel nijel self-assigned this Nov 16, 2017

@nijel nijel closed this in 6ba0098 Nov 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment