New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13727 by removing <small> elements which contains the number of ordered by columns" #13813

Closed
wants to merge 13 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@xypXiong
Contributor

xypXiong commented Nov 14, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@@ -286,7 +286,8 @@ AJAX.registerOnload('sql.js', function () {
});
$('.table_results .column_heading a').each(function () {
textArea.value += $(this).text() + '\t';
//remove <small> elements which contains the number of ordered by columns
textArea.value +=($(this).remove("small")).text() + '\t';

This comment has been minimized.

@nijel

nijel Nov 16, 2017

Member

Doesn't this remove the elements from the page? So that they are no longer visible after copying the text?

@nijel

nijel Nov 16, 2017

Member

Doesn't this remove the elements from the page? So that they are no longer visible after copying the text?

@xypXiong

This comment has been minimized.

Show comment
Hide comment
@xypXiong

xypXiong Nov 16, 2017

Contributor
Contributor

xypXiong commented Nov 16, 2017

@xypXiong

This comment has been minimized.

Show comment
Hide comment
@xypXiong

xypXiong Nov 16, 2017

Contributor
Contributor

xypXiong commented Nov 16, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 28, 2017

Member

I guess this is superseded by #13823.

Member

nijel commented Nov 28, 2017

I guess this is superseded by #13823.

@nijel nijel closed this Nov 28, 2017

@nijel nijel self-assigned this Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment