New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use templates for some of Display/Results methods #13819

Merged
merged 9 commits into from Nov 19, 2017

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Nov 19, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Nov 16, 2017

Use template for _getShowAllCheckboxForTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _getAdditionalFieldsForTableNavigation
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _getTableNavigationButton
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _getOptionsBlock
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _getFormForMultiRowOperations
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _getCommentForRow
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _buildValueDisplay
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _buildNullDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for _buildEmptyDisplay method
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Nov 19, 2017

@mauriciofauth mauriciofauth self-assigned this Nov 19, 2017

@mauriciofauth mauriciofauth merged commit d498b0c into phpmyadmin:master Nov 19, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 6 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:display-results branch Nov 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment