New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #13727 Copied table data add "1" after column name which had order by parameter #13823

Merged
merged 2 commits into from Nov 28, 2017

Conversation

Projects
None yet
3 participants
@xypXiong
Contributor

xypXiong commented Nov 20, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

xypXiong added some commits Nov 20, 2017

@phpmyadmin-bot

This comment has been minimized.

Show comment
Hide comment
@phpmyadmin-bot

phpmyadmin-bot Nov 20, 2017

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/sql.js

phpmyadmin-bot commented on 172499b Nov 20, 2017

This commit is using tab character for indentation instead of spaces, what is mandated by phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/sql.js

@nijel nijel self-assigned this Nov 28, 2017

@nijel nijel added this to the 4.8.0 milestone Nov 28, 2017

@nijel nijel merged commit f65c3dc into phpmyadmin:master Nov 28, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codacy/pr Good work! A positive pull request.
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Nov 28, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Nov 28, 2017

Merged, thanks for your contribution!

@nijel nijel referenced this pull request Nov 28, 2017

Closed

More descriptive text for ASC/DESC sort order #13751

4 of 4 tasks complete
@xypXiong

This comment has been minimized.

Show comment
Hide comment
@xypXiong

xypXiong Nov 28, 2017

Contributor
Contributor

xypXiong commented Nov 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment