New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhpMyAdmin\Display\Import class #13834

Merged
merged 21 commits into from Nov 26, 2017

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Nov 25, 2017

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Nov 23, 2017

Use template for getHtmlForImportOptionsSubmit
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportOptions
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForHiddenInputs
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportWithPlugin
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportWithPlugin method
Replace getHtmlForImportWithPlugin method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportJs
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportCompressions
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportCharset
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForHiddenInputs method
Replace getHtmlForHiddenInputs method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportJs method
Replace getHtmlForImportJs method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportCompressions method
Replace getHtmlForImportCompressions method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptions method
Replace getHtmlForImportOptions method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportCharset method
Replace getHtmlForImportCharset method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptionsPartialImport method
Replace getHtmlForImportOptionsPartialImport method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptionsOther method
Replace getHtmlForImportOptionsOther method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptionsFormat method
Replace getHtmlForImportOptionsFormat method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptionsSubmit method
Replace getHtmlForImportOptionsSubmit method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use template for getHtmlForImportOptionsFile
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Remove getHtmlForImportOptionsFile method
Replace getHtmlForImportOptionsFile method with the template call.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Nov 25, 2017

@mauriciofauth mauriciofauth self-assigned this Nov 25, 2017

mauriciofauth added some commits Nov 25, 2017

Use template for getHtmlForImport
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Refactor PhpMyAdmin\Display\Import class
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 26, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@337ec5a). Click here to learn what that means.
The diff coverage is 30.3%.

@@            Coverage Diff            @@
##             master   #13834   +/-   ##
=========================================
  Coverage          ?   53.81%           
=========================================
  Files             ?      492           
  Lines             ?    81096           
  Branches          ?        0           
=========================================
  Hits              ?    43639           
  Misses            ?    37457           
  Partials          ?        0

codecov bot commented Nov 26, 2017

Codecov Report

❗️ No coverage uploaded for pull request base (master@337ec5a). Click here to learn what that means.
The diff coverage is 30.3%.

@@            Coverage Diff            @@
##             master   #13834   +/-   ##
=========================================
  Coverage          ?   53.81%           
=========================================
  Files             ?      492           
  Lines             ?    81096           
  Branches          ?        0           
=========================================
  Hits              ?    43639           
  Misses            ?    37457           
  Partials          ?        0

@mauriciofauth mauriciofauth merged commit ed396da into phpmyadmin:master Nov 26, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:display-import branch Nov 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment