New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation for ShowColumnComments #13844

Merged
merged 1 commit into from Nov 29, 2017

Conversation

Projects
None yet
2 participants
@ibennetch
Member

ibennetch commented Nov 28, 2017

Signed-off-by: Isaac Bennetch bennetch@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Documentation for ShowColumnComments
Signed-off-by: Isaac Bennetch <bennetch@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Nov 28, 2017

Codecov Report

Merging #13844 into QA_4_7 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           QA_4_7   #13844   +/-   ##
=======================================
  Coverage    52.7%    52.7%           
=======================================
  Files         467      467           
  Lines       80316    80316           
=======================================
  Hits        42329    42329           
  Misses      37987    37987

codecov bot commented Nov 28, 2017

Codecov Report

Merging #13844 into QA_4_7 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           QA_4_7   #13844   +/-   ##
=======================================
  Coverage    52.7%    52.7%           
=======================================
  Files         467      467           
  Lines       80316    80316           
=======================================
  Hits        42329    42329           
  Misses      37987    37987

@mauriciofauth mauriciofauth merged commit 603a685 into phpmyadmin:QA_4_7 Nov 29, 2017

4 of 5 checks passed

codacy/pr Codacy was unable to analyse your pull request.
Details
DCO All commits have a DCO sign-off from the author
codecov/patch Coverage not affected when comparing 713fcd4...8e1469c
Details
codecov/project 52.7% remains the same compared to 713fcd4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Nov 29, 2017

@mauriciofauth mauriciofauth added this to the 4.7.6 milestone Nov 29, 2017

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Nov 29, 2017

Member

Merged. Thanks, Isaac.

Member

mauriciofauth commented Nov 29, 2017

Merged. Thanks, Isaac.

@ibennetch ibennetch deleted the ibennetch:columncomment branch Jun 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment