New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PHPUnit 5 #13862

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
3 participants
@carusogabriel
Contributor

carusogabriel commented Dec 12, 2017

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

I've added PHPUnit 5 support.

Support PHPUnit 5
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 12, 2017

Codecov Report

Merging #13862 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #13862      +/-   ##
============================================
+ Coverage     55.35%   55.36%   +<.01%     
- Complexity        0    14425   +14425     
============================================
  Files           493      493              
  Lines         70666    70674       +8     
============================================
+ Hits          39119    39128       +9     
+ Misses        31547    31546       -1

codecov bot commented Dec 12, 2017

Codecov Report

Merging #13862 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #13862      +/-   ##
============================================
+ Coverage     55.35%   55.36%   +<.01%     
- Complexity        0    14425   +14425     
============================================
  Files           493      493              
  Lines         70666    70674       +8     
============================================
+ Hits          39119    39128       +9     
+ Misses        31547    31546       -1

@mauriciofauth mauriciofauth self-assigned this Dec 12, 2017

@mauriciofauth mauriciofauth merged commit 7292598 into phpmyadmin:master Dec 12, 2017

6 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 5 new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 533f3ff...930af7e
Details
codecov/project 55.36% (+<.01%) compared to 533f3ff
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Dec 12, 2017

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Dec 12, 2017

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Dec 12, 2017

Merged, thanks for your contribution!

@carusogabriel carusogabriel deleted the carusogabriel:phpunit-5 branch Dec 12, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 14, 2017

Member

This seems to lead to problems with Selenium tests as it leads to older phpunit-selenium being used. I will try to address this in #13867

Member

nijel commented Dec 14, 2017

This seems to lead to problems with Selenium tests as it leads to older phpunit-selenium being used. I will try to address this in #13867

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment