New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring tests #13863

Merged
merged 1 commit into from Dec 12, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Dec 12, 2017

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

I've refactored some tests, using:

  • assertCount instead of count function;
  • assertSame instead of strict comparison ===;
  • assertNull instead of comparison with null keyword;
  • assertFalse and assertNotFalse instead of comparison with false keyword;
  • assertArrayHasKey and assertArrayNotHasKey instead of isset function.
Refactoring tests
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>

@mauriciofauth mauriciofauth self-assigned this Dec 12, 2017

@mauriciofauth mauriciofauth merged commit 8be5072 into phpmyadmin:master Dec 12, 2017

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Dec 12, 2017

@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Dec 12, 2017

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Dec 12, 2017

Merged, thanks for your contribution!

@carusogabriel carusogabriel deleted the carusogabriel:refactoring-tests branch Dec 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment