New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to use more recent phpunit-selenium #13867

Merged
merged 2 commits into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@nijel
Member

nijel commented Dec 14, 2017

Signed-off-by: Michal Čihař michal@cihar.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@nijel nijel self-assigned this Dec 14, 2017

@nijel nijel referenced this pull request Dec 14, 2017

Merged

Support PHPUnit 5 #13862

4 of 4 tasks complete
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 14, 2017

Codecov Report

Merging #13867 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13867   +/-   ##
=========================================
  Coverage     55.37%   55.37%           
  Complexity    14425    14425           
=========================================
  Files           493      493           
  Lines         70659    70659           
=========================================
  Hits          39127    39127           
  Misses        31532    31532

codecov bot commented Dec 14, 2017

Codecov Report

Merging #13867 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13867   +/-   ##
=========================================
  Coverage     55.37%   55.37%           
  Complexity    14425    14425           
=========================================
  Files           493      493           
  Lines         70659    70659           
=========================================
  Hits          39127    39127           
  Misses        31532    31532
@carusogabriel

This comment has been minimized.

Show comment
Hide comment
@carusogabriel
Contributor

carusogabriel commented Dec 14, 2017

@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 15, 2017

Member

Yes that's what I've noticed as well, but in the end this was not the root cause - the root cause was stuck BrowserStack and bad error handling in the on phpunit-selenium which got pulled in after this PR.

Member

nijel commented Dec 15, 2017

Yes that's what I've noticed as well, but in the end this was not the root cause - the root cause was stuck BrowserStack and bad error handling in the on phpunit-selenium which got pulled in after this PR.

@nijel nijel changed the title from Try to use more recepnt phpunit-selenium to Try to use more recent phpunit-selenium Dec 15, 2017

nijel added some commits Dec 14, 2017

Use more recent phpunit-selenium
We can't yet use 4.0 due to it's dependency on current phpunit, but at
least upgrade to 3.0.

Signed-off-by: Michal Čihař <michal@cihar.com>
Remove type hinting from onNotSuccessfulTest
Upstream has removed that as well.

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel merged commit d1ac2f8 into phpmyadmin:master Dec 15, 2017

6 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 11d236b...4c2c38f
Details
codecov/project 55.37% remains the same compared to 11d236b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@nijel nijel deleted the nijel:selenium branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment