New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean elses #13868

Merged
merged 1 commit into from Dec 15, 2017

Conversation

Projects
None yet
2 participants
@carusogabriel
Contributor

carusogabriel commented Dec 14, 2017

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

I've removed the elses when we have already returned something 馃毊

Clean elses
Signed-off-by: Gabriel Caruso <carusogabriel34@gmail.com>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 15, 2017

Codecov Report

Merging #13868 into master will increase coverage by <.01%.
The diff coverage is 46.26%.

@@             Coverage Diff              @@
##             master   #13868      +/-   ##
============================================
+ Coverage     55.36%   55.36%   +<.01%     
  Complexity    14425    14425              
============================================
  Files           493      493              
  Lines         70674    70673       -1     
============================================
  Hits          39128    39128              
+ Misses        31546    31545       -1

codecov bot commented Dec 15, 2017

Codecov Report

Merging #13868 into master will increase coverage by <.01%.
The diff coverage is 46.26%.

@@             Coverage Diff              @@
##             master   #13868      +/-   ##
============================================
+ Coverage     55.36%   55.36%   +<.01%     
  Complexity    14425    14425              
============================================
  Files           493      493              
  Lines         70674    70673       -1     
============================================
  Hits          39128    39128              
+ Misses        31546    31545       -1

@nijel nijel merged commit 7a83d83 into phpmyadmin:master Dec 15, 2017

3 of 5 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
codecov/patch 46.26% of diff hit (target 55.36%)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
codecov/project 55.36% (+<.01%) compared to dfbbff0
Details
@nijel

This comment has been minimized.

Show comment
Hide comment
@nijel

nijel Dec 15, 2017

Member

Merged, thanks for your contribution!

Member

nijel commented Dec 15, 2017

Merged, thanks for your contribution!

@nijel nijel self-assigned this Dec 15, 2017

@carusogabriel carusogabriel deleted the carusogabriel:clean-elses branch Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment