New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles from elements #13883

Merged
merged 3 commits into from Dec 23, 2017

Conversation

Projects
None yet
2 participants
@Juvenv
Contributor

Juvenv commented Dec 23, 2017

Signed-off-by: Juvenildo Vaz juvenildo1511@yahoo.com.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Juvenv added some commits Dec 23, 2017

Juvenv
Remove inline styles from elements in index.php #12262
Signed-off-by: Juvenv <jorgecabral264@yahoo.com.br>
Juvenv
Remove inline style from element in CentralColumns #12262
Signed-off-by: Juvenv <jorgecabral264@yahoo.com.br>
Juvenv
Remove inline style from element in CentralColumns #12262
Signed-off-by: Juvenv <jorgecabral264@yahoo.com.br>
@codecov

This comment has been minimized.

Show comment
Hide comment
@codecov

codecov bot Dec 23, 2017

Codecov Report

Merging #13883 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master   #13883   +/-   ##
=========================================
  Coverage     55.33%   55.33%           
  Complexity    14420    14420           
=========================================
  Files           493      493           
  Lines         70556    70556           
=========================================
  Hits          39045    39045           
  Misses        31511    31511

codecov bot commented Dec 23, 2017

Codecov Report

Merging #13883 into master will not change coverage.
The diff coverage is 50%.

@@            Coverage Diff            @@
##             master   #13883   +/-   ##
=========================================
  Coverage     55.33%   55.33%           
  Complexity    14420    14420           
=========================================
  Files           493      493           
  Lines         70556    70556           
=========================================
  Hits          39045    39045           
  Misses        31511    31511
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Dec 23, 2017

Member

Hello, @Juvenv. Thanks for your contribution!

Could you use your real name in the signature tag?
For example: Signed-off-by: Jane Developer <jane@example.org>

See Developer's Certificate of Origin

Member

mauriciofauth commented Dec 23, 2017

Hello, @Juvenv. Thanks for your contribution!

Could you use your real name in the signature tag?
For example: Signed-off-by: Jane Developer <jane@example.org>

See Developer's Certificate of Origin

@Juvenv

This comment has been minimized.

Show comment
Hide comment
@Juvenv

Juvenv Dec 23, 2017

Contributor

Hello, @mauriciofauth, i changed signature in the pull request, just in previous commits, i not got (it is hard for me!). The best i do was duplicate the line Signed-off-by.

Contributor

Juvenv commented Dec 23, 2017

Hello, @mauriciofauth, i changed signature in the pull request, just in previous commits, i not got (it is hard for me!). The best i do was duplicate the line Signed-off-by.

@mauriciofauth mauriciofauth merged commit 561c6bf into phpmyadmin:master Dec 23, 2017

5 of 6 checks passed

codecov/patch 50% of diff hit (target 55.33%)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/project 55.33% remains the same compared to 80a6279
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Show comment
Hide comment
@mauriciofauth

mauriciofauth Dec 23, 2017

Member

Merged, thanks for your contribution!

Member

mauriciofauth commented Dec 23, 2017

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Dec 23, 2017

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Dec 23, 2017

@mauriciofauth mauriciofauth changed the title from Remove inline style from element in CentralColumns #12262 to Remove inline styles from elements Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment