Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Fix charset error when creating/editing routines; bug #13889 #13892
@@ Coverage Diff @@ ## master #13892 +/- ## ============================================ + Coverage 55.44% 55.44% +<.01% - Complexity 14359 14360 +1 ============================================ Files 494 494 Lines 70455 70456 +1 ============================================ + Hits 39061 39062 +1 Misses 31394 31394
nijel left a comment
I think this is wrong approach - it should be rather fixed server side to not generate CHARSET part of the query in this case.
Your approach will lead to problems as well in case user changes the type several times - the charset field will be emptied leading to losing this information while editing.