New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force PHP platform in composer to oldest supported version #13917

Merged
merged 1 commit into from Jan 16, 2018

Conversation

Projects
None yet
3 participants
@nijel
Member

nijel commented Jan 8, 2018

This way the packages should be compatible with all versions we support
regardless PHP version used to build the release.

Fixes #13831

Signed-off-by: Michal Čihař michal@cihar.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Force PHP platform in composer to oldest supported version
This way the packages should be compatible with all versions we support
regardless PHP version used to build the release.

Fixes #13831

Signed-off-by: Michal Čihař <michal@cihar.com>

@nijel nijel self-assigned this Jan 8, 2018

@codecov

This comment has been minimized.

codecov bot commented Jan 13, 2018

Codecov Report

Merging #13917 into QA_4_7 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           QA_4_7   #13917   +/-   ##
=======================================
  Coverage   54.29%   54.29%           
=======================================
  Files         467      467           
  Lines       70244    70244           
=======================================
  Hits        38137    38137           
  Misses      32107    32107

@nijel nijel merged commit fb92eca into phpmyadmin:QA_4_7 Jan 16, 2018

4 of 5 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
DCO All commits have a DCO sign-off from the author
codecov/patch Coverage not affected when comparing 2ceb241...009246e
Details
codecov/project 54.29% remains the same compared to 2ceb241
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@OlafvdSpek

This comment has been minimized.

OlafvdSpek commented on 009246e Jan 16, 2018

Doesn't composer support a declarative way to do this?
If it doesn't, a feature request might make sense.

This comment has been minimized.

Member

ibennetch replied Jan 16, 2018

Just to keep the comment thread intact, I'll copy and paste Michal's response from #13917 (comment):

Yes, it can be set in composer.json, but we don't want to force this in all cases, just for the generated releases to be sure they are compatible with oldest supported PHP version.

@nijel nijel deleted the nijel:release-composer-php branch Jan 16, 2018

@nijel

This comment has been minimized.

Member

nijel commented Jan 16, 2018

Yes, it can be set in composer.json, but we don't want to force this in all cases, just for the generated releases to be sure they are compatible with oldest supported PHP version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment