Remove font size feature #13925
Remove font size feature #13925
Conversation
#13919 Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #13925 +/- ##
=========================================
Coverage ? 52.89%
Complexity ? 14326
=========================================
Files ? 492
Lines ? 63665
Branches ? 0
=========================================
Hits ? 33676
Misses ? 29989
Partials ? 0 |
|
Apparently you just remove the font size form. The font size feature goes beyond that. |
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
@MauricioFauth is this good? |
|
In addition to removing the form, I think removing the |
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
Hi @shucon I tried restarting the selenium job but the same test I'd recommend you to try running the test locally (or run down the flow manually), if it fails that'd mean that your changes in this PR unknowingly seem to have broken the flow being tested in the above test or the test has been broken since a last few commits but no one caught it.
|
|
Also, I can see an error on the settings page saying: 'Field FontSize has no type' which seems related to this PR. |
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
@devenbansod both the issues are fixed on my side , can you please confirm the same . |
| ); | ||
|
|
||
| //test getFontsizeOptions for "em" unit | ||
| $fontsize = $GLOBALS['PMA_Config']->get('FontSize'); |
There was a problem hiding this comment.
There are more places where the FontSize setting is used with the Config class.
Signed-off-by: Thomas Wong <ufosaga@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Fix textarea failed to popup (issue #13518)
|
This pull request is incomplete, there are still several places where the FontSize configuration is used. |
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
@MauricioFauth is this sufficient? |
themes/pmahomme/css/common.css.php
Outdated
| @@ -14,9 +14,6 @@ | |||
| ?> | |||
| /******************************************************************************/ | |||
| /* general tags */ | |||
| html { | |||
| font-size: <?php echo $theme->getFontSize(); ?> | |||
| } | |||
There was a problem hiding this comment.
You need to keep the font-size property here.
| @@ -1191,13 +1191,7 @@ public function getSource() | |||
| */ | |||
| public function getThemeUniqueValue() | |||
There was a problem hiding this comment.
You should update the doc for this method to reflect the changes.
There was a problem hiding this comment.
I can't find anything related to this in the doc, please help.
There was a problem hiding this comment.
I'm referring to the comment block just above the method.
|
I don't think it's a good idea to include this in 4.8 branch. This is a major change and should only be included in 5.0 branch. |
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
@MauricioFauth everything good now? |
doc/config.rst
Outdated
| :default: '82%' | ||
|
|
||
| Font size to use, is applied in CSS. | ||
|
|
There was a problem hiding this comment.
I don't think this should be simply removed. See this example: 8cc6de4#diff-5a2f160c43a637ce34c72d79c769e4cf
There was a problem hiding this comment.
Okay, got it! I'll fix it.
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
doc/config.rst
Outdated
| @@ -3232,6 +3232,11 @@ Theme manager settings | |||
|
|
|||
| :type: string | |||
| :default: '82%' | |||
|
|
|||
| .. deprecated:: 4.8.0 | |||
There was a problem hiding this comment.
Please, change to 5.0.0. Thanks!
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
|
Merged! Thank you for your contribution and your patience with the various requests for change. |
#13919
Signed-off-by: Saksham Gupta shucon01@gmail.com
Before submitting pull request, please check that every commit: