New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove inline styles in ReplicationGui.php #13981

Merged
merged 5 commits into from Mar 24, 2018

Conversation

Projects
None yet
3 participants
@Anu4ruby
Contributor

Anu4ruby commented Feb 9, 2018

Hi Please evaluate my pull request for the issue 12262- Remove inline styles in ReplicationGui.php. I have added the signed off message in my commit message but for some reason it is not detected. Am I doing any mistake while writing the commit message? Thank you.

@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on b7c950e Feb 9, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

Anu4ruby added some commits Feb 9, 2018

removed inline styles from AuthenticationConfig.php- file-issue 12262…
…-Signed-off-by: Anupama.V <sadicarnot@gmail.com>
@Anu4ruby removed inline styles from AuthenticationConfig.php file fo…
…r issue 12262- adding signoff message -Signed-off-by: Anupama.V <sadicarnot@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 71182e2 Feb 9, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on b591211 Feb 9, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@codecov

This comment has been minimized.

codecov bot commented Feb 9, 2018

Codecov Report

Merging #13981 into master will not change coverage.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #13981   +/-   ##
=========================================
  Coverage     55.41%   55.41%           
  Complexity    14356    14356           
=========================================
  Files           494      494           
  Lines         70408    70408           
=========================================
  Hits          39020    39020           
  Misses        31388    31388

@Anu4ruby Anu4ruby changed the title from Remove inline styles in ReplicationGui.php- issue 12262 to Remove inline styles in ReplicationGui.php- issue 12262- Signed-off-by: Anupama <sadicarnot@gmail.com> Feb 10, 2018

@mauriciofauth mauriciofauth changed the title from Remove inline styles in ReplicationGui.php- issue 12262- Signed-off-by: Anupama <sadicarnot@gmail.com> to Remove inline styles in ReplicationGui.php Mar 24, 2018

@mauriciofauth mauriciofauth merged commit 65e3074 into phpmyadmin:master Mar 24, 2018

5 of 6 checks passed

DCO The sign-off is missing.
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch 100% of diff hit (target 55.41%)
Details
codecov/project 55.41% (+0%) compared to 5efb29d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 24, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 24, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 24, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment