Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for broken profiling; issue #13969 #13983

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@nulll-pointer
Copy link
Contributor

commented Feb 9, 2018

Changed file ./libraries/common.inc.php
Removed member header from line '$response->getHeader()->header->getScripts()', there is no such member.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix for issue #13969
Changed file ./libraries/common.inc.php
Removed member header from line '$response->getHeader()->header->getScripts()', there is no such member.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

@ibennetch ibennetch changed the title Fix for issue #13969 Fix for broken profiling; issue #13969 Feb 10, 2018

@codecov

This comment has been minimized.

Copy link

commented Feb 10, 2018

Codecov Report

Merging #13983 into master will not change coverage.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #13983   +/-   ##
=========================================
  Coverage     55.41%   55.41%           
  Complexity    14356    14356           
=========================================
  Files           494      494           
  Lines         70408    70408           
=========================================
  Hits          39020    39020           
  Misses        31388    31388

@mauriciofauth mauriciofauth merged commit 767f073 into phpmyadmin:master Feb 16, 2018

4 of 5 checks passed

codecov/patch 0% of diff hit (target 55.41%)
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/project 55.41% remains the same compared to 5efb29d
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 16, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.