Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix case in which Config::checkServers is never called #13988

Merged
merged 1 commit into from Feb 12, 2018

Conversation

Projects
None yet
1 participant
@mauriciofauth
Copy link
Member

commented Feb 10, 2018

If there is no configuration file, the Config::checkServers() method will never be called.

Fix #13769

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix case in which checkServers is never called
If there is no configuration file, the checkServers() method will never be called.

Fix #13769

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 10, 2018

@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2018

Codecov Report

Merging #13988 into master will decrease coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #13988      +/-   ##
============================================
- Coverage     55.43%   55.43%   -0.01%     
  Complexity    14358    14358              
============================================
  Files           494      494              
  Lines         70453    70453              
============================================
- Hits          39059    39058       -1     
- Misses        31394    31395       +1

@mauriciofauth mauriciofauth self-assigned this Feb 12, 2018

@mauriciofauth mauriciofauth merged commit 1bde549 into phpmyadmin:master Feb 12, 2018

4 of 6 checks passed

codecov/patch 0% of diff hit (target 55.43%)
Details
codecov/project 55.43% (-0.01%) compared to d61fba6
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:issue-13769 branch Feb 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.