Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Hover on tables #13998

Merged
merged 2 commits into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@shucon
Copy link
Contributor

commented Feb 12, 2018

Fixes: #13980

Signed-off-by: Saksham Gupta shucon01@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

shucon added some commits Feb 12, 2018

Fixes Hover on tables
Fixes: #13980

Signed-off-by: Saksham Gupta <shucon01@gmail.com>
Travis Rerun
Signed-off-by: Saksham Gupta <shucon01@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2018

Codecov Report

Merging #13998 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #13998      +/-   ##
============================================
- Coverage     55.43%   55.43%   -0.01%     
- Complexity    14358    14359       +1     
============================================
  Files           494      494              
  Lines         70453    70455       +2     
============================================
+ Hits          39059    39060       +1     
- Misses        31394    31395       +1
@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

@shucon Adding an empty commit is not recommended. If necessary, we will restart a Travis-CI build manually.

@mauriciofauth mauriciofauth merged commit 9fc96ed into phpmyadmin:master Feb 16, 2018

5 of 6 checks passed

codecov/project 55.43% (-0.01%) compared to 607ed03
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 607ed03...8af6cf9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 16, 2018

@shucon

This comment has been minimized.

Copy link
Contributor Author

commented Feb 16, 2018

Okay I'll take care of it next time.

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.