Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix table horizontal scrolling #14001

Merged
merged 2 commits into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@nulll-pointer
Copy link
Contributor

commented Feb 12, 2018

Changed files:
themes/original/css/common.css.php
themes/pmahomme/css/common.css.php
Added style definition for .responsivetable element to prevent horizontal overflow
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix for issue 13959
Changed files:
	themes/original/css/common.css.php
	themes/pmahomme/css/common.css.php
Added style definition for .responsivetable element to prevent horizontal overflow
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)
@@ -3323,6 +3323,10 @@
display: none;
}

.responsivetable {
overflow-x: auto !important;

This comment has been minimized.

Copy link
@mauriciofauth

mauriciofauth Feb 12, 2018

Member

Using !important is generally not recommended. Could you solve it differently?

This comment has been minimized.

Copy link
@nulll-pointer

nulll-pointer Feb 12, 2018

Author Contributor

It works without !important i just added it for safety reasons.

This comment has been minimized.

Copy link
@nulll-pointer

nulll-pointer Feb 12, 2018

Author Contributor

i could remove it if you suggest.

@codecov

This comment has been minimized.

Copy link

commented Feb 12, 2018

Codecov Report

Merging #14001 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14001   +/-   ##
=========================================
  Coverage     55.43%   55.43%           
  Complexity    14359    14359           
=========================================
  Files           494      494           
  Lines         70455    70455           
=========================================
  Hits          39060    39060           
  Misses        31395    31395
Fix for issue #13959
Changed files:
themes/original/css/common.css.php
themes/pmahomme/css/common.css.php
Added style definition for .responsivetable element to prevent horizontal overflow
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

@mauriciofauth mauriciofauth changed the title Fix for issue #13959 Fix table horizontal scrolling Feb 16, 2018

@mauriciofauth mauriciofauth merged commit e92b357 into phpmyadmin:master Feb 16, 2018

5 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 1bde549...180a1e6
Details
codecov/project 55.43% remains the same compared to 1bde549
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 16, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Merged, thanks for your contribution!

mauriciofauth added a commit that referenced this pull request Apr 25, 2018

Revert "Fix table horizontal scrolling (#14001)"
This reverts commit e92b357.

This fixes #14193, fixes #14029, fixes #14199, fixes #14102 and fixes #14232

This closes #14196 and closes #14206

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@BePsvPT BePsvPT referenced this pull request Jun 19, 2018

Closed

fix table horizontal scrolling bug #14403

2 of 4 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.