Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translated using Weblate (Filipino) #14006

Merged
merged 1 commit into from Feb 20, 2018
Merged

Translated using Weblate (Filipino) #14006

merged 1 commit into from Feb 20, 2018

Conversation

@codygee237
Copy link
Contributor

@codygee237 codygee237 commented Feb 13, 2018

This is a continuation to the Filipino Language Translation (fil.po)
Currently translated at more than 1300 words out of 21,349 words and more than 250 strings translated out of 3208 strings

Signed-off-by: codygee237 35871138+codygee237@users.noreply.github.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
This is a continuation to the Filipino Language Translation (fil.po)
Currently translated at more than 1300 words at 21,349 words and more than 250 strings out of 3208 strings


Signed-off-by: codygee237 <35871138+codygee237@users.noreply.github.com>
@codygee237
Copy link
Contributor Author

@codygee237 codygee237 commented Feb 15, 2018

Hi Good Day Sir! I am still waiting for the approval. I'm hoping for your positive feedback Sir. Thank you

@nijel nijel merged commit 474b820 into phpmyadmin:master Feb 20, 2018
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
@dco
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
@nijel
Copy link
Contributor

@nijel nijel commented Feb 20, 2018

Merged, thanks for your contribution!

Any reason for not making changes in Weblate directly?

@nijel nijel self-assigned this Feb 20, 2018
@nijel nijel added this to the 4.8.0 milestone Feb 20, 2018
nijel added a commit that referenced this pull request Feb 20, 2018
Issue #14006

Signed-off-by: Michal Čihař <michal@cihar.com>
@nijel
Copy link
Contributor

@nijel nijel commented Feb 20, 2018

Also you've made several mistakes in the po file, what would not happen when editing in Weblate, see bacdc21

@codygee237
Copy link
Contributor Author

@codygee237 codygee237 commented Feb 21, 2018

@thank you Sir! I'm really sorry I was not able to make changes on it because I was so busy for the past weeks. I hope you'd understand. Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants