New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors on zoom search errors, issue #13439 #14012

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@nulll-pointer
Contributor

nulll-pointer commented Feb 14, 2018

Problem 1:
The number of td elements in the zoom search form table were insufficient, due to which, the field_type(element #types_$) was getting replaced with field_value(element td:eq(3))(see ./js/tbl_zoom_jqplot.js lines 164, 188, 211, 232). Added a td element in the table for each row.
Problem 2:
The events attached to 'tableid_$' were inserting the values in wrong tr elements(see ./js/tbl_zoom_jqplot.js lines 185-188, 208-211, 229-232), leading to wrong values being passed to the zoom search.
Signed-Off-By: Lakshay arora(b16060@students.iitmandi.ac.in)
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fix for issue #13439
Problem 1:
The number of td elements in the zoom search form table were insufficient, due to which, the field_type(element #types_$) was getting replaced with field_value(element td:eq(3))(see ./js/tbl_zoom_jqplot.js lines 164, 188, 211, 232). Added a td element in the table for each row.
Problem 2:
The events attached to 'tableid_$' were inserting the values in wrong tr elements(see ./js/tbl_zoom_jqplot.js lines 185-188, 208-211, 229-232), leading to wrong values being passed to the zoom search.
Signed-Off-By: Lakshay arora(b16060@students.iitmandi.ac.in)
@codecov

This comment has been minimized.

codecov bot commented Feb 14, 2018

Codecov Report

Merging #14012 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14012   +/-   ##
=========================================
  Coverage     55.43%   55.43%           
  Complexity    14360    14360           
=========================================
  Files           494      494           
  Lines         70457    70457           
=========================================
  Hits          39061    39061           
  Misses        31396    31396

@ibennetch ibennetch changed the title from Fix for issue #13439 to Fix errors on zoom search errors, issue #13439 Feb 17, 2018

@mauriciofauth mauriciofauth self-assigned this Mar 29, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 29, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 29, 2018

Merged in 85c975f.
Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment