Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PhpMyAdmin\CreateAddField class #14015

Merged
merged 3 commits into from Feb 15, 2018

Conversation

Projects
None yet
1 participant
@mauriciofauth
Copy link
Member

commented Feb 15, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Feb 15, 2018

Replace static methods with instance methods
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Fix coding style issues
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Use DI for DatabaseInterface instance
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Feb 15, 2018

Codecov Report

Merging #14015 into master will increase coverage by <.01%.
The diff coverage is 46.75%.

@@             Coverage Diff              @@
##             master   #14015      +/-   ##
============================================
+ Coverage     55.44%   55.45%   +<.01%     
- Complexity    14360    14361       +1     
============================================
  Files           494      494              
  Lines         70459    70486      +27     
============================================
+ Hits          39063    39085      +22     
- Misses        31396    31401       +5

@mauriciofauth mauriciofauth merged commit dac7dcc into phpmyadmin:master Feb 15, 2018

4 of 6 checks passed

Codacy/PR Quality Review Not so good... This pull request quality could be better.
Details
codecov/patch 46.75% of diff hit (target 55.44%)
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 3 updated code elements – Tests: passed
Details
codecov/project 55.45% (+<.01%) compared to ff06650
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:create-add-field branch Feb 15, 2018

@mauriciofauth mauriciofauth self-assigned this Feb 15, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 15, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.