Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons with wrong size in the Original theme #14020

Merged
merged 1 commit into from Feb 16, 2018

Conversation

Projects
None yet
2 participants
@ramantehlan
Copy link
Contributor

commented Feb 16, 2018

Signed-off-by: Raman Tehlan ramantehlan@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Final Patch for issue #14013

Signed-off-by: Raman Tehlan <ramantehlan@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Feb 16, 2018

Codecov Report

Merging #14020 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14020   +/-   ##
=========================================
  Coverage     55.45%   55.45%           
  Complexity    14361    14361           
=========================================
  Files           494      494           
  Lines         70486    70486           
=========================================
  Hits          39085    39085           
  Misses        31401    31401

@mauriciofauth mauriciofauth changed the title Final Patch for issue #14013 Fix icons with wrong size in the Original theme Feb 16, 2018

@mauriciofauth mauriciofauth self-assigned this Feb 16, 2018

@mauriciofauth mauriciofauth merged commit e2d0928 into phpmyadmin:master Feb 16, 2018

6 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 5b79f37...1323bee
Details
codecov/project 55.45% remains the same compared to 5b79f37
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 16, 2018

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Feb 16, 2018

Merged, thanks for your contribution! 👍

@ramantehlan ramantehlan deleted the ramantehlan:FinalPatch_#14013 branch Mar 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.