Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set console max height, issue #14022 #14024

Merged
merged 1 commit into from Feb 20, 2018
Merged

Set console max height, issue #14022 #14024

merged 1 commit into from Feb 20, 2018

Conversation

@aroralakshya
Copy link
Contributor

@aroralakshya aroralakshya commented Feb 17, 2018

Changed:
js/console.js
Before showing the console, set the height to minimum between current set height and height of the display window.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Changed:
	js/console.js
Before showing the console, set the height to minimum between current set height and height of the display window.
Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)
@nijel nijel self-assigned this Feb 20, 2018
@nijel nijel added this to the 4.8.0 milestone Feb 20, 2018
@nijel nijel merged commit 9efa57d into phpmyadmin:master Feb 20, 2018
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: 1 new issues – Tests: passed
Details
@nijel
Copy link
Member

@nijel nijel commented Feb 20, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.