New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error in foreign key sql generation + drop foreign key contraint #14031

Merged
merged 2 commits into from Mar 27, 2018

Conversation

Projects
None yet
4 participants
@nulll-pointer
Contributor

nulll-pointer commented Feb 20, 2018

Changed:
templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Signed-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fixes error in foreign key sql genration, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Sign-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 0348d52 Feb 20, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@Gemorroj

This comment has been minimized.

Contributor

Gemorroj commented Feb 20, 2018

I think it is also necessary to correct the error display.
The response "success: true", which is wrong.

@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Feb 24, 2018

I thing making success:false also expects an error parameter in the json object returned, the error is generated during parsing so i'm still figuring out how to put the error in parsing with the response object..

Fixes error in foreign key sql generation + drop foreign key contrain…
…t, issue #14030

Changed:
	templates/table/relation/foreign_key_row.twig
Signed-Off-By : Lakshay arora (b16060@students.iitmandi.ac.in)
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 5fe3064 Feb 24, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@codecov

This comment has been minimized.

codecov bot commented Feb 24, 2018

Codecov Report

Merging #14031 into master will increase coverage by 0.14%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14031      +/-   ##
============================================
+ Coverage      55.3%   55.44%   +0.14%     
  Complexity    14364    14364              
============================================
  Files           494      494              
  Lines         70511    70522      +11     
============================================
+ Hits          38993    39104     +111     
+ Misses        31518    31418     -100

@nulll-pointer nulll-pointer changed the title from Fixes error in foreign key sql generation, issue #14030 to Fixes error in foreign key sql generation + drop foreign key contraint Feb 24, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 25, 2018

Related to #13941

@mauriciofauth mauriciofauth merged commit 00b5962 into phpmyadmin:master Mar 27, 2018

5 of 6 checks passed

DCO The sign-off is missing.
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing fe3bed2...5fe3064
Details
codecov/project 55.44% (+0.14%) compared to fe3bed2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 27, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth self-assigned this Mar 27, 2018

@mauriciofauth mauriciofauth modified the milestones: 4.8.0, 4.8.1 Mar 27, 2018

mauriciofauth added a commit that referenced this pull request Mar 27, 2018

Fixes error in foreign key sql generation + drop foreign key contraint (
#14031)

* Fixes error in foreign key sql genration, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig
The destination_column_names were getting passed as a 1d array, the names when extracted gave a string. Passing it as a 2d array (see templates/table/relation/foreign_key_row.twig lines 123,133) fixes the issue.

Sign-Off-By: Lakshay arora (b16060@students.iitmandi.ac.in)

* Fixes error in foreign key sql generation + drop foreign key contraint, issue #14030
Changed:
	templates/table/relation/foreign_key_row.twig

Fix #13941
Fix #14009
Close #14037
Close #14010

Signed-off-by: Lakshay arora <b16060@students.iitmandi.ac.in>
(cherry picked from commit 00b5962)
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment