Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Broken Designer Add Table #14035

merged 1 commit into from Mar 1, 2018

Fix Broken Designer Add Table #14035

merged 1 commit into from Mar 1, 2018


Copy link

@shucon shucon commented Feb 21, 2018

Fixes: #14034

Signed-off-by: Saksham Gupta

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fixes: #14034

Signed-off-by: Saksham Gupta <>
Copy link

@codecov codecov bot commented Feb 21, 2018

Codecov Report

Merging #14035 into master will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14035   +/-   ##
  Coverage     55.44%   55.44%           
  Complexity    14364    14364           
  Files           494      494           
  Lines         70513    70513           
  Hits          39097    39097           
  Misses        31416    31416
@nijel nijel self-assigned this Mar 1, 2018
@nijel nijel merged commit de365e9 into phpmyadmin:master Mar 1, 2018
6 checks passed
6 checks passed
Codacy/PR Quality Review Good work! A positive pull request.
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 1 new issues – Tests: passed
codecov/patch Coverage not affected when comparing 5c2f63b...de365e9
codecov/project 55.44% remains the same compared to 5c2f63b
continuous-integration/travis-ci/pr The Travis CI build passed
@nijel nijel added this to the 4.8.0 milestone Mar 1, 2018
Copy link

@nijel nijel commented Mar 1, 2018

Merged, thanks for your contribution!

@nijel nijel mentioned this pull request Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants