Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix broken sort #14036
Conversation
mauriciofauth
requested a review
from
nijel
Feb 22, 2018
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Feb 22, 2018
•
Codecov Report
@@ Coverage Diff @@
## QA_4_7 #14036 +/- ##
==========================================
- Coverage 54.29% 54.26% -0.03%
==========================================
Files 467 467
Lines 70253 70189 -64
==========================================
- Hits 38141 38090 -51
+ Misses 32112 32099 -13 |
nijel
requested changes
Feb 22, 2018
•
Seems like some fixes from master are still missing. Here is list of related fixes in master and at least first few ones are missing, I haven't checked rest:
- 1fc566f Share code for parsing data-post attribute
- 2bc8721 Adjust RTE oprations to use POST
- 613a146 Adjust field drop to use POST
- 7508205 Adjust optimize table to use POST
- 599a981 Adjust partition manipulations to use POST
- e7eaea8 Adjust browsing distinct values to use POST
- 6ee2f12 Adjust adding table key operations to use POST
- 8332861 Adjust table drop operation to use POST
- ff20564 Adjust table truncate operation to use POST
- 99e9854 Always use POST for links containing SQL query
- 816c426 Add tests for Util::linkOrButton
- 3b9fb2b Simplify handling of long URLs in Util::linkOrButton
mauriciofauth
and others
added some commits
Feb 22, 2018
This comment has been minimized.
This comment has been minimized.
|
@nijel What do you think now? |
nijel
self-assigned this
Feb 22, 2018
nijel
merged commit c21a9cf
into
phpmyadmin:QA_4_7
Feb 22, 2018
1 of 2 checks passed
continuous-integration/travis-ci/pr
The Travis CI build failed
Details
DCO
All commits have a DCO sign-off from the author
This comment has been minimized.
This comment has been minimized.
|
I think it's good to merge now, thanks! Still this needs heavy testing now to discover possible breakages... |
nijel
added this to the 4.7.9 milestone
Feb 22, 2018
mauriciofauth
deleted the
mauriciofauth:broken-sort
branch
Feb 22, 2018
This comment has been minimized.
This comment has been minimized.
|
This should ideally fix the issue at #13887 too, right? |
nijel
referenced this pull request
Mar 1, 2018
Closed
4.7.7: PHP Warning: Unknown: Input variables exceeded 1000. To increase the limit change max_input_vars in php.ini. #13887
mauriciofauth
referenced this pull request
Mar 1, 2018
Closed
Edit not working when 50 plus rows is showing. #13922
added a commit
that referenced
this pull request
Mar 1, 2018
nijel
referenced this pull request
Mar 1, 2018
Closed
Form has over 1000 fields error/Not an integer error when showing all rows #13927
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mauriciofauth commentedFeb 22, 2018
•
edited
Fix #13931
Related to #13887