@@ Coverage Diff @@ ## QA_4_7 #14036 +/- ## ========================================== - Coverage 54.29% 54.26% -0.03% ========================================== Files 467 467 Lines 70253 70189 -64 ========================================== - Hits 38141 38090 -51 + Misses 32112 32099 -13
nijel left a comment •
Seems like some fixes from master are still missing. Here is list of related fixes in master and at least first few ones are missing, I haven't checked rest:
This reverts commit 44df4a3. Signed-off-by: Maurício Meneghini Fauth <firstname.lastname@example.org>
We no longer create form, but rather rather tag the link to be handled as POST on the client side. This way the code is way simpler without need on any special case handling on server side. Fixes #13649 Signed-off-by: Michal Čihař <email@example.com> (cherry picked from commit 3b9fb2b) Signed-off-by: Maurício Meneghini Fauth <firstname.lastname@example.org>
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.