Fix broken sort #14036
Merged
Fix broken sort #14036
+279
−293
Conversation
Codecov Report
@@ Coverage Diff @@
## QA_4_7 #14036 +/- ##
==========================================
- Coverage 54.29% 54.26% -0.03%
==========================================
Files 467 467
Lines 70253 70189 -64
==========================================
- Hits 38141 38090 -51
+ Misses 32112 32099 -13 |
Seems like some fixes from master are still missing. Here is list of related fixes in master and at least first few ones are missing, I haven't checked rest:
|
This reverts commit 44df4a3. Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
We no longer create form, but rather rather tag the link to be handled as POST on the client side. This way the code is way simpler without need on any special case handling on server side. Fixes #13649 Signed-off-by: Michal Čihař <michal@cihar.com> (cherry picked from commit 3b9fb2b) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Signed-off-by: Michal Čihař <michal@cihar.com> (cherry picked from commit 816c426) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
This way the SQL queries will not apper in the web server logs. Signed-off-by: Michal Čihař <michal@cihar.com> (cherry picked from commit 99e9854) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
83c91f0
to
fc6cb86
fc6cb86
to
106c60c
dataPost can be undefined Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com> (cherry picked from commit 367f49b) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
fix maintenance operations Signed-off-by: Gemorroj <wapinet@gmail.com> (cherry picked from commit b3c9a0c) Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
106c60c
to
031c832
@nijel What do you think now? |
c21a9cf
into
phpmyadmin:QA_4_7
1 of 2 checks passed
1 of 2 checks passed
DCO
All commits have a DCO sign-off from the author
I think it's good to merge now, thanks! Still this needs heavy testing now to discover possible breakages... |
This should ideally fix the issue at #13887 too, right? |
nijel
added a commit
that referenced
this pull request
Mar 1, 2018
Signed-off-by: Michal Čihař <michal@cihar.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fix #13931
Related to #13887