New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename PMD to Designer #14042

Merged
merged 8 commits into from Feb 24, 2018

Conversation

Projects
None yet
1 participant
@mauriciofauth
Member

mauriciofauth commented Feb 24, 2018

PMD does not have much meaning these days and may confuse new developers.

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

mauriciofauth added some commits Feb 24, 2018

Rename PmdCommon to Database\Designer\Common
Rename PhpMyAdmin\PmdCommon to PhpMyAdmin\Database\Designer\Common.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Replace static methods with instance methods
Replace PhpMyAdmin\Database\Designer\Common static methods with instance methods.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Rename js/pmd directory to js/designer
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Rename $GLOBALS['PMD'] to $GLOBALS['designer']
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Rename img/pmd directory to img/designer
Rename themes/pmahomme/img/pmd directory to themes/pmahomme/img/designer.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Rename css/pmd.css.php to css/designer.css.php
Rename themes/pmahomme/css/pmd.css.php to themes/pmahomme/css/designer.css.php.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Replace pmd* in CSS classes and IDs with designer*
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Add changelog entry
Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Feb 24, 2018

Codecov Report

Merging #14042 into master will increase coverage by <.01%.
The diff coverage is 17.82%.

@@             Coverage Diff              @@
##             master   #14042      +/-   ##
============================================
+ Coverage     55.44%   55.44%   +<.01%     
  Complexity    14364    14364              
============================================
  Files           494      494              
  Lines         70522    70523       +1     
============================================
+ Hits          39102    39104       +2     
+ Misses        31420    31419       -1

@mauriciofauth mauriciofauth merged commit 6281074 into phpmyadmin:master Feb 24, 2018

4 of 5 checks passed

codecov/patch 17.82% of diff hit (target 55.44%)
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 19 new issues, 319 updated code elements – Tests: passed
Details
codecov/project 55.44% (+<.01%) compared to 17bf8b7
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth deleted the mauriciofauth:pmd branch Feb 24, 2018

@mauriciofauth mauriciofauth self-assigned this Feb 24, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Feb 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment