Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFixes adding new column in query builder, #14047 #14048
Conversation
This comment has been minimized.
This comment has been minimized.
codecov
bot
commented
Mar 1, 2018
•
Codecov Report
@@ Coverage Diff @@
## master #14048 +/- ##
============================================
+ Coverage 55.43% 55.43% +<.01%
Complexity 14364 14364
============================================
Files 494 494
Lines 70544 70544
============================================
+ Hits 39103 39105 +2
+ Misses 31441 31439 -2 |
nijel
self-assigned this
Mar 1, 2018
nijel
added this to the 4.8.0 milestone
Mar 1, 2018
nijel
merged commit befd2de
into
phpmyadmin:master
Mar 1, 2018
5 of 6 checks passed
DCO
The sign-off is missing.
Details
Codacy/PR Quality Review
Good work! A positive pull request.
Details
Scrutinizer
Analysis: No new issues – Tests: passed
Details
codecov/patch
Coverage not affected when comparing 68d42ce...915c945
Details
codecov/project
55.43% (+<.01%) compared to 68d42ce
Details
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
This comment has been minimized.
This comment has been minimized.
|
Merged, thanks for your contribution! |
nulll-pointer
deleted the
nulll-pointer:query_builder
branch
Mar 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nulll-pointer commentedMar 1, 2018
•
edited
Fixes #14047
Signed-off-by: Lakshay arora(arora.lakshay123@gmail.com)
Before submitting pull request, please check that every commit: