New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes adding new column in query builder, #14047 #14048

Merged
merged 1 commit into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@nulll-pointer
Contributor

nulll-pointer commented Mar 1, 2018

Fixes #14047
Signed-off-by: Lakshay arora(arora.lakshay123@gmail.com)

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Fixes #14047
Signed-off-by: Lakshay arora(arora.lakshay123@gmail.com)
@codecov

This comment has been minimized.

codecov bot commented Mar 1, 2018

Codecov Report

Merging #14048 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14048      +/-   ##
============================================
+ Coverage     55.43%   55.43%   +<.01%     
  Complexity    14364    14364              
============================================
  Files           494      494              
  Lines         70544    70544              
============================================
+ Hits          39103    39105       +2     
+ Misses        31441    31439       -2

@nijel nijel self-assigned this Mar 1, 2018

@nijel nijel added this to the 4.8.0 milestone Mar 1, 2018

@nijel nijel merged commit befd2de into phpmyadmin:master Mar 1, 2018

5 of 6 checks passed

DCO The sign-off is missing.
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 68d42ce...915c945
Details
codecov/project 55.43% (+<.01%) compared to 68d42ce
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nijel

This comment has been minimized.

Member

nijel commented Mar 1, 2018

Merged, thanks for your contribution!

@nulll-pointer nulll-pointer deleted the nulll-pointer:query_builder branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment