Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix buggy sql.lib.php on debian9 with PHP7.2 #14064

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@gonzo4711
Copy link

commented Mar 7, 2018

Fixed the exception (Warning in ./libraries/sql.lib.php#613 count(): Parameter must be an array or an object that implements Countable)
bracket at the wrong position

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

Signed-off-by: Gonzo info@gonzo-online.de

Fix buggy sql.lib.php on debian9 with PHP7.2
Fixed the exception (Warning in ./libraries/sql.lib.php#613  count(): Parameter must be an array or an object that implements Countable)
bracket at the wrong position
@phpmyadmin-bot

This comment has been minimized.

Copy link

commented on 37d1950 Mar 7, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

@ibennetch

This comment has been minimized.

Copy link
Member

commented Mar 10, 2018

Hello and thanks
Thanks for your contribution. Your pull request is failing the tests because you haven't used the "signed off by" command with your commit to indicate that you agree with the Developer's Certificate of Origin document, which ensures that the work you've done is your own.

The best way to fix it is to amend your commit using the --signoff flag (such as git commit --amend --signoff) and push the changes back to your branch (you'll need to force the push with -f or --force).

@ibennetch

This comment has been minimized.

Copy link
Member

commented Mar 10, 2018

Is there an existing issue in the bug tracker for this behavior?

@batabyalsunny

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2018

@ibennetch There are multiple issues reported for this e.g. #14052

Please see the last comment here #13932 It is still an issue with PHP 7.2 or later.

@ibennetch

This comment has been minimized.

Copy link
Member

commented Mar 21, 2018

This patch looks good to me, but I'm not set up to test against PHP 7.2 at the moment and @nijel was just working on this bit of code for 4ef752e. Michal, could you take a look at this?

@ibennetch

This comment has been minimized.

Copy link
Member

commented Mar 21, 2018

@gonzo4711 Your pull request currently lacks a sign off message indicating that the pull request is your original content, see more at https://github.com/probot/dco#how-it-works.

If you agree, and if your Git has your full name and email address configured (see https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup), you can amend your commit and add the -s flag like git commit -s or git commit --amend --signoff

@gonzo4711

This comment has been minimized.

Copy link
Author

commented Mar 21, 2018

@ibennetch Thx for the information. There's another bug I found in combination with PHP 7.2.

I'll commit a new patch with a correct signed-off message.

@mauriciofauth

This comment has been minimized.

Copy link
Member

commented Mar 24, 2018

Sorry. This has already been fixed in #13413.

@mauriciofauth mauriciofauth self-assigned this Mar 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.