Central columns attributes don't get filled in #12772 issue solved #14073
Conversation
This comment has been minimized.
This comment has been minimized.
This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information. |
Signed-off-by: aswani <aswani15prakash@gmail.com>
…yadmin into aswaniprakash
Codecov Report
@@ Coverage Diff @@
## master #14073 +/- ##
============================================
+ Coverage 55.43% 55.43% +<.01%
Complexity 14365 14365
============================================
Files 494 494
Lines 70546 70547 +1
============================================
+ Hits 39104 39106 +2
+ Misses 31442 31441 -1 |
Signed-off-by: aswani <aswani15prakash@gmail.com>
This comment has been minimized.
This comment has been minimized.
This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information. Offending files: js/db_multi_table_query.js |
Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
} | ||
else{ | ||
query += ', `' + escapeBacktick(columns[i][0]) + '`.`' + escapeBacktick(columns[i][1]) + '`'; | ||
} |
mauriciofauth
Mar 30, 2018
Member
This does not seem to be related to the issue. What is the reason for the changes in this file?
This does not seem to be related to the issue. What is the reason for the changes in this file?
mauriciofauth
Mar 30, 2018
Member
I just saw that these changes are related to #14049. Could you open a new pull request containing only those changes?
I just saw that these changes are related to #14049. Could you open a new pull request containing only those changes?
Hello, @aswaniprakash. Thanks for your contribution. Several of these files now have their executable bit set (their mode changes from 644 to 755 with this pull request); could you fix that? |
Closed in favor of #14226. |
Signed-off-by: Aswani Prakash aswani15prakash@gmail.com
Before submitting pull request, please check that every commit: