Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Central columns attributes don't get filled in #12772 issue solved #14073

Closed
wants to merge 6 commits into from

Conversation

aswaniprakash
Copy link
Contributor

@aswaniprakash aswaniprakash commented Mar 12, 2018

Signed-off-by: Aswani Prakash aswani15prakash@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

@codecov
Copy link

codecov bot commented Mar 13, 2018

Codecov Report

Merging #14073 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #14073      +/-   ##
============================================
+ Coverage     55.43%   55.43%   +<.01%     
  Complexity    14365    14365              
============================================
  Files           494      494              
  Lines         70546    70547       +1     
============================================
+ Hits          39104    39106       +2     
+ Misses        31442    31441       -1

Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
Signed-off-by: aswani <aswani15prakash@gmail.com>
}
else{
query += ', `' + escapeBacktick(columns[i][0]) + '`.`' + escapeBacktick(columns[i][1]) + '`';
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not seem to be related to the issue. What is the reason for the changes in this file?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw that these changes are related to #14049. Could you open a new pull request containing only those changes?

@MauricioFauth
Copy link
Member

MauricioFauth commented Mar 30, 2018

Hello, @aswaniprakash. Thanks for your contribution.

Several of these files now have their executable bit set (their mode changes from 644 to 755 with this pull request); could you fix that?

@MauricioFauth
Copy link
Member

Closed in favor of #14226.

@MauricioFauth MauricioFauth self-assigned this Apr 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants