New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable columns names by default for CSV in issue #14007 solved #14076

Merged
merged 3 commits into from Apr 5, 2018

Conversation

Projects
None yet
2 participants
@rijaspk
Contributor

rijaspk commented Mar 13, 2018

Enable columns names by default for CSV
Added a export type check for CSV
IF true added csv columns
fixes #14007

Signed-off-by: Rijas Ahammed PK Rijaspk5195@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

codecov bot commented Mar 13, 2018

Codecov Report

Merging #14076 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@             Coverage Diff              @@
##             master   #14076      +/-   ##
============================================
- Coverage     55.44%   55.43%   -0.01%     
+ Complexity    14382    14366      -16     
============================================
  Files           494      494              
  Lines         70686    70549     -137     
============================================
- Hits          39190    39108      -82     
+ Misses        31496    31441      -55
“Rijas “Rijas
Improve formatting
Signed-off-by: “Rijas <“Rijas.Ahammed@icfoss.in”>
//Enable columns names by default for CSV
if($what == 'csv')
$GLOBALS['csv_columns'] = 'yes';

This comment has been minimized.

@mauriciofauth

mauriciofauth Mar 30, 2018

Member

Hi, @rijaspk. Thanks for your contribution.
Before we can merge your pull request, we would like you to make the following changes.
The body of the if structure must be enclosed by braces and there must be a space between the if keyword and the parenthesis.

This comment has been minimized.

@rijaspk

rijaspk Apr 2, 2018

Contributor

Hi, @mauriciofauth. Required changes are implemented.

“Rijas “Rijas
Follow formatting standard
Enclosed body of if statement within braces
Add space between if keyword and paranthesis

Signed-off-by: “Rijas <“Rijas.Ahammed@icfoss.in”>

@mauriciofauth mauriciofauth merged commit d6ca2d2 into phpmyadmin:master Apr 5, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth self-assigned this Apr 5, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Apr 5, 2018

Merged, thanks for your contribution!

@mauriciofauth mauriciofauth added this to the 5.0.0 milestone Apr 5, 2018

@rijaspk

This comment has been minimized.

Contributor

rijaspk commented Apr 6, 2018

Hi, @mauriciofauth Thanks for reveiwing and accepting my PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment