New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error 404 on creating views, issue #14082 #14092

Merged
merged 1 commit into from Mar 29, 2018

Conversation

Projects
None yet
3 participants
@nulll-pointer
Contributor

nulll-pointer commented Mar 17, 2018

Signed-off-by: Lakshay arora arora.lakshya123@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 29c4538 Mar 29, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: libraries/classes/Util.php

@codecov

This comment has been minimized.

codecov bot commented Mar 29, 2018

Codecov Report

Merging #14092 into master will increase coverage by <.01%.
The diff coverage is 75%.

@@             Coverage Diff              @@
##             master   #14092      +/-   ##
============================================
+ Coverage     55.44%   55.44%   +<.01%     
- Complexity    14373    14375       +2     
============================================
  Files           494      494              
  Lines         70616    70620       +4     
============================================
+ Hits          39150    39153       +3     
- Misses        31466    31467       +1
Fixes error 404 on creating views, issue #14082
Signed-off-by: Lakshay arora <arora.lakshya123@gmail.com>

@mauriciofauth mauriciofauth merged commit be03257 into phpmyadmin:master Mar 29, 2018

5 of 6 checks passed

DCO Expected "Lakshay arora <carefreelakshay97@gmail.com>", but got "Lakshay arora <arora.lakshya123@gmail.com>".
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: 1 updated code elements – Tests: passed
Details
codecov/patch 75% of diff hit (target 55.44%)
Details
codecov/project 55.44% (+<.01%) compared to 695fe3a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 29, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment