New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JavaScript error in Designer: getElementById() #14079 issue fix #14097

Closed
wants to merge 10 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@aswaniprakash
Contributor

aswaniprakash commented Mar 19, 2018

JavaScript error in Designer: getElementById() #14079 issue fix

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on b9fc484 Mar 12, 2018

This commit is missing Signed-Off-By line to indicate that you agree with phpMyAdmin Developer's Certificate of Origin. Please check contributing documentation for more information.

aswaniprakash added some commits Mar 13, 2018

query builder issue #14049 fix
Signed-off-by: aswani <aswani15prakash@gmail.com>
query builder issue #14049 fix
Signed-off-by: aswani <aswani15prakash@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 90fbcc3 Mar 13, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: js/db_multi_table_query.js

aswaniprakash added some commits Mar 13, 2018

query builder issue #14049 fix
Signed-off-by: aswani <aswani15prakash@gmail.com>
code quality issue fixed
Signed-off-by: aswani <aswani15prakash@gmail.com>
JavaScript error in Designer: getElementById() #14079 issue fix
Signed-off-by: aswani <aswani15prakash@gmail.com>
JavaScript error in Designer: getElementById() #14079 issue fix
Signed-off-by: aswani <aswani15prakash@gmail.com>
@ibennetch

This comment has been minimized.

Member

ibennetch commented Mar 21, 2018

Could you please use your full name for the signoff message? You can configure that in Git with git config --global user.name "Mona Lisa" (or omit the --global if you wish to only change it for one repository).

@ibennetch

Several of these files now have their executable bit set (their mode changes from 644 to 755 with this pull request); could you fix that?

aswaniprakash added some commits Mar 27, 2018

File permission corrected #14079
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
File permission changed #14079
Signed-off-by: Aswani Prakash <aswani15prakash@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Mar 27, 2018

Codecov Report

Merging #14097 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14097      +/-   ##
============================================
+ Coverage     55.43%   55.43%   +<.01%     
  Complexity    14366    14366              
============================================
  Files           494      494              
  Lines         70550    70549       -1     
============================================
+ Hits          39106    39108       +2     
+ Misses        31444    31441       -3
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

Hi, @aswaniprakash. Thank for your contribution!

#14079 has been fixed by ca7fd2b and so I will close this pull request. For more information see comments #14079 (comment) and #14079 (comment).

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@aswaniprakash aswaniprakash deleted the aswaniprakash:PMA_14079 branch Apr 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment