New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot read property sql_query of undefined: #14104 issue fix #14105

Merged
merged 2 commits into from Mar 26, 2018

Conversation

Projects
None yet
3 participants
@Piyush3079
Contributor

Piyush3079 commented Mar 21, 2018

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

codecov bot commented Mar 21, 2018

Codecov Report

Merging #14105 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master   #14105      +/-   ##
============================================
+ Coverage      55.4%    55.4%   +<.01%     
  Complexity    14364    14364              
============================================
  Files           494      494              
  Lines         70501    70500       -1     
============================================
+ Hits          39061    39063       +2     
+ Misses        31440    31437       -3
Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
Cannot read property sql_query of undefined: #14104 issue fix
Signed-off-by: Piyush Vijay <piyushvijay.1997@gmail.com>
document.sqlform.sql_query.value = query;
document.sqlform.sql_query.focus();
} else {

This comment has been minimized.

@CommanderRoot

CommanderRoot Mar 24, 2018

Contributor

This else part is redundant as the function already ends here

@mauriciofauth mauriciofauth merged commit ad86eab into phpmyadmin:master Mar 26, 2018

6 checks passed

Codacy/PR Quality Review Good work! A positive pull request.
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 4 new issues – Tests: passed
Details
codecov/patch Coverage not affected when comparing 1e134bb...c1559f6
Details
codecov/project 55.42% (+<.01%) compared to 1e134bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 26, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 26, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 26, 2018

Merged, thanks for your contribution!

@Piyush3079 Piyush3079 deleted the Piyush3079:sql_query_error branch Mar 26, 2018

mauriciofauth added a commit that referenced this pull request Apr 6, 2018

Revert "Cannot read property sql_query of undefined: #14104 issue fix (
…#14105)"

This reverts commit ad86eab.

Signed-off-by: Maurício Meneghini Fauth <mauriciofauth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment