New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes JavaScript error when editing rows with Internet Explorer #14108

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@ibennetch
Member

ibennetch commented Mar 21, 2018

Fixes JavaScript error when editing rows with Internet Explorer

Fixes #14060
Fixes #14096

Internet Explorer does not support StartsWith()

See the comments by
tm8544 at #14096 (comment)
and qcybb at #14060 (comment)

Signed-off-by: Isaac Bennetch bennetch@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@codecov

This comment has been minimized.

codecov bot commented Mar 21, 2018

Codecov Report

Merging #14108 into QA_4_7 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           QA_4_7   #14108   +/-   ##
=======================================
  Coverage   54.27%   54.27%           
=======================================
  Files         467      467           
  Lines       70181    70181           
=======================================
  Hits        38092    38092           
  Misses      32089    32089
Fixes JavaScript error when editing rows with Internet Explorer
Fixes #14060
Fixes #14096

Internet Explorer does not support StartsWith()

See the comments by
tm8544 at #14096 (comment)
and qcybb at #14060 (comment)

Signed-off-by: Isaac Bennetch <bennetch@gmail.com>

@ibennetch ibennetch changed the title from Fix for #14060, JavaScript error when editing rows with Internet Explorer to Fixes JavaScript error when editing rows with Internet Explorer Mar 21, 2018

@mauriciofauth mauriciofauth merged commit 6fc885c into phpmyadmin:QA_4_7 Mar 23, 2018

4 of 5 checks passed

Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
DCO All commits have a DCO sign-off from the author
codecov/patch Coverage not affected when comparing f90fdf2...4d7ca8f
Details
codecov/project 54.27% remains the same compared to f90fdf2
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 23, 2018

@mauriciofauth mauriciofauth added this to the 4.7.10 milestone Mar 23, 2018

@ibennetch ibennetch modified the milestones: 4.7.10, 4.8.0 May 25, 2018

@ibennetch ibennetch deleted the ibennetch:ie_compatibility branch Jun 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment