New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designer: Add options dialog is pre-filled with spaces #14111 issue fix #14114

Merged
merged 1 commit into from Mar 30, 2018

Conversation

Projects
None yet
2 participants
@vyeshwanth
Contributor

vyeshwanth commented Mar 22, 2018

Signed-off-by: vyeshwanth vyeshwanth123@gmail.com

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

Hello. Thanks for your contribution!

Could you use your real name in the signature tag?
For example: Signed-off-by: Jane Developer <jane@example.org>

See Developer's Certificate of Origin

Designer: Add options dialog is pre-filled with spaces #14111 issue fix
Signed-off-by: Yeshwanth Vuppu <vyeshwanth123@gmail.com>
@codecov

This comment has been minimized.

codecov bot commented Mar 30, 2018

Codecov Report

❗️ No coverage uploaded for pull request base (master@cec81ae). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #14114   +/-   ##
=========================================
  Coverage          ?   55.42%           
  Complexity        ?    14366           
=========================================
  Files             ?      494           
  Lines             ?    70533           
  Branches          ?        0           
=========================================
  Hits              ?    39095           
  Misses            ?    31438           
  Partials          ?        0

@mauriciofauth mauriciofauth merged commit 9a8ed9c into phpmyadmin:master Mar 30, 2018

2 of 4 checks passed

DCO Expected "vyeshwanth <vyeshwanth123@gmail.com>", but got "Yeshwanth Vuppu <vyeshwanth123@gmail.com>".
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
Codacy/PR Quality Review Good work! A positive pull request.
Details
Scrutinizer Analysis: No new issues – Tests: passed
Details

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment