New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for "Export tables as seperate files", #14080 #14115

Closed
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@nulll-pointer
Contributor

nulll-pointer commented Mar 23, 2018

Signed-off-by: Lakshay arora carefreelakshay97@gmail.com

@ibennetch
Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests

EDIT:

Used code sniffer.

Fix for "Export tables as seperate files", #14080
Signed-off-by: Lakshay arora <carefreelakshay97@gmail.com>
@phpmyadmin-bot

This comment has been minimized.

phpmyadmin-bot commented on 80aa919 Mar 23, 2018

This commit contains trailing whitespace, what is prohibited in phpMyAdmin. Please check our Developer guidelines for more information.

Offending files: libraries/classes/ZipExtension.php

Fix for "Export tables as seperate files", #14080
Applied code sniffer.

Signed-off-by: Lakshay arora <carefreelakshay97@gmail.com>
@nulll-pointer

This comment has been minimized.

Contributor

nulll-pointer commented Mar 26, 2018

I came up with the solution by seeing how export files is implemented in the stable branch where it works perfectly.

@mauriciofauth mauriciofauth self-assigned this Mar 30, 2018

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 30, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 30, 2018

Merged, thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment