New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addapt getHtmlForTableNavigation to twig template #14116

Merged
merged 1 commit into from Mar 23, 2018

Conversation

Projects
None yet
2 participants
@laps15
Contributor

laps15 commented Mar 23, 2018

Signed-off-by: Leonardo Strozzi laps15@inf.ufpr.br

Before submitting pull request, please check that every commit:

  • Has proper Signed-Off-By
  • Has commit message which describes it
  • Is needed on it's own, if you have just minor fixes to previous commits, you can squash them
  • Any new functionality is covered by tests
Addapt getHtmlForTableNavigation to twig template
Signed-off-by: Leonardo Strozzi <laps15@inf.ufpr.br>

@mauriciofauth mauriciofauth merged commit f0b6e41 into phpmyadmin:master Mar 23, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
DCO All commits have a DCO sign-off from the author
Scrutinizer Analysis: 2 updated code elements – Tests: passed
Details

@mauriciofauth mauriciofauth added this to the 4.8.0 milestone Mar 23, 2018

@mauriciofauth mauriciofauth self-assigned this Mar 23, 2018

@mauriciofauth

This comment has been minimized.

Member

mauriciofauth commented Mar 23, 2018

Merged, thanks for your contribution!

@laps15, I suggest you to create a branch to commit your changes. It's not recommended to commit directly to the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment